Restrict nightly node labeler to linux (docker) only #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
|
does the DSL CI test cover the code that is changed here? |
It does not. It only works on generated XML Jenkins jobs https://github.com/gazebo-tooling/release-tools/blob/master/jenkins-scripts/dsl/dsl_checks.bash#L105-L118 |
Crola1702
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly node selector was using plain
large-memorylabel as criteria. After the inclusion of the Windows nodes with GPU and large-memory labels the nightly node was broken selecting Windows machines.The PR adds the docker (linux only) tag to the expression. That required to modify the searches a bit to support label expressions and not single label matches.