Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Types #9

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Add Types #9

merged 3 commits into from
Apr 25, 2024

Conversation

bh2smith
Copy link
Contributor

@bh2smith bh2smith commented Apr 21, 2024

All libraries depending on this package are running into this mypy error:

error: Skipping analyzing "near_lake_framework": module is installed, but missing library stubs or py.typed marker  [import-untyped]
note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

It should be as straightforward as adding this empty py.typed file and including it in the setup.py file.

Test Plan

  1. Build the project locally python -m build.
  2. Install the local build in a project that depends on it (e.g. https://github.com/near/gas-station-event-indexer) pip install -e ../near_lake_framework
  3. Run mypy (see no more missing library stubs warnings)...

After step 1 you can also unzip the build and see that the py.typed file is included in the build.

Note that there were additional type errors (referenced in #10). If this is accepted this PR also closes #10.

I think we should also BUMP the required python version of this package to at least 3.8, but preferably >=3.9.

@bh2smith bh2smith marked this pull request as draft April 21, 2024 21:20
@bh2smith bh2smith marked this pull request as ready for review April 22, 2024 09:18
@frolvanya
Copy link
Owner

Thanks for your contribution! I'll test all your PRs soon and merge them

@frolvanya frolvanya merged commit af1220c into frolvanya:main Apr 25, 2024
1 check passed
@bh2smith bh2smith deleted the add-types branch May 29, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This Constructor Doesn't Return a Class Instance
2 participants