Armbe8 patches #1130
Merged
Armbe8 patches #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleavr
requested changes
Jan 9, 2025
src/linux/frida-helper-backend.vala
Outdated
| @@ -1988,7 +1988,11 @@ namespace Frida { | |||
| #elif ARM | |||
| target_address &= ~1; | |||
|
|
|||
| # if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ | |||
There was a problem hiding this comment.
Does the Vala compiler define this?
There was a problem hiding this comment.
Yeah. It seems to work just fine. Without the change it dies.
There was a problem hiding this comment.
ISTM this will always be false, because I can't see the Vala compiler defining this. (Just grepped through the codebase.)
There was a problem hiding this comment.
I am setting the CFLAGS environment variable before I run ./configure and make to set -mbe8 and it seems to work ok for me. Without this change frida-inject seems to fail? Perhaps vala still uses the C pre-processor and that's why this works?
There was a problem hiding this comment.
Let me check this and confirm that it is working as expected.
oleavr
requested changes
Jan 14, 2025
src/linux/helpers/loader.c
Outdated
| /* avoid inline initialization to prevent the compiler attempting to insert a call to memset */ | ||
| /* | ||
| * Avoid inline initialization to prevent the compiler attempting to insert | ||
| * a call to memset. |
src/linux/helpers/loader.c
Outdated
| /* avoid inline initialization to prevent the compiler attempting to insert a call to memset */ | ||
| /* | ||
| * Avoid inline initialization to prevent the compiler attempting to insert | ||
| * a call to memset. |
WorksButNotTested
force-pushed
the
armbe8-patches
branch
from
a9f79f1 to
b390702
Compare
|
Thanks! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to support ARMBE8