-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Convert use of Vagrant to podman-compose for tests #617
Draft
abbra
wants to merge
4
commits into
freeipa:main
Choose a base branch
from
abbra:use-freeipa-gitub-action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbra
force-pushed
the
use-freeipa-gitub-action
branch
2 times, most recently
from
January 14, 2025 09:03
8996dad
to
dd65e3e
Compare
abbra
changed the title
Convert use of Vagrant to podman-compose for tests
WIP: Convert use of Vagrant to podman-compose for tests
Jan 14, 2025
I'm trying to understand why container build is not working at the moment. Perhaps, this is a networking issue as I cannot reproduce it locally. |
abbra
force-pushed
the
use-freeipa-gitub-action
branch
12 times, most recently
from
January 14, 2025 11:48
ee137dd
to
e8e3e01
Compare
rjeffman
reviewed
Jan 14, 2025
abbra
force-pushed
the
use-freeipa-gitub-action
branch
from
January 14, 2025 12:48
e8e3e01
to
c233f86
Compare
abbra
force-pushed
the
use-freeipa-gitub-action
branch
2 times, most recently
from
January 17, 2025 19:34
6280d82
to
692f962
Compare
Instead of Vagrant use ipalab-config and podman-compose. ipalab-config github action allows to automatically create FreeIPA environments using ansible-freeipa and run ansible playbooks against these environments. Switch to ubuntu-latest as ubuntu 20.04 is too old for podman use Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
abbra
force-pushed
the
use-freeipa-gitub-action
branch
from
January 19, 2025 10:44
692f962
to
61e780f
Compare
In general: adding a host entry requires its name to be resolvable over DNS. Since we don't have those DNS entries yet, we should use 'Force' checkbox. Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
abbra
force-pushed
the
use-freeipa-gitub-action
branch
from
January 19, 2025 12:00
61e780f
to
b5fab21
Compare
'ipa host-add foo.bar.z --force' is a valid command. We do not require IP address being present in this case. This is essential for adding virtual hosts that manage Kerberos services. See ipatests/test_xmlrpc/test_service_plugin.py, for example. There are plenty of tests that use 'host_add' with 'force=True'. Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
abbra
force-pushed
the
use-freeipa-gitub-action
branch
from
January 20, 2025 09:25
a64b129
to
14c228b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of Vagrant use ipalab-config and podman-compose.
ipalab-config github action allows to automatically create FreeIPA environments using ansible-freeipa and run ansible playbooks against these environments.