[Active users][Settings][Account settings] Add functionality for checkbox list #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma12
force-pushed
the
account-settings-checkbox-list
branch
from
6182301 to
79e95b0
Compare
|
This PR depends on this one to be merged: #136 |
carma12
force-pushed
the
account-settings-checkbox-list
branch
4 times, most recently
from
b83dadc to
1b1d6ff
Compare
pvoborni
requested changes
Sep 4, 2023
There was a problem hiding this comment.
Thanks for the PR. Added few comments.
There is also one issue which we will probably need to deal with soon - when comparing if we did any changes, the order of values in array might matter in the comparison but in some cases it might not matter in IPA itself.
carma12
force-pushed
the
account-settings-checkbox-list
branch
from
1b1d6ff to
6583906
Compare
|
The code has been updated and amended based on most of the feedback requested above. Some conversations still need to be clarified. |
pvoborni
reviewed
Sep 5, 2023
carma12
force-pushed
the
account-settings-checkbox-list
branch
from
6583906 to
ab3f564
Compare
|
Updated the code based on feedback provided. |
The functionality for the group of checkboxes needs to be implemented and applied to the following field: 'User authentication types' (`ipauserauthtype`). Signed-off-by: Carla Martinez <carlmart@redhat.com>
carma12
force-pushed
the
account-settings-checkbox-list
branch
from
ab3f564 to
add1e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality for the group of checkboxes has been implemented and applied to the following field: 'User authentication types' (
ipauserauthtype).