Skip to content

Commit

Permalink
Temporarily pin PyMuPDF==1.23.8 in container
Browse files Browse the repository at this point in the history
PyMuPDF 1.23.9 made the swapped the new fitz implementation (fitz_new)
with the fitz module. In the new module there are prints in the code
that interfere with our stderror for sending JSON from the container.
Pinning the version seems to have no adverse consequences [1], since
fitz_old hasn't had significant changes and it gives breething room for
the print-related issue to be tackled in PR [2].

Fixes temporarily #700

[1]: #700 (comment)
[2]: pymupdf/PyMuPDF#3137
  • Loading branch information
deeplow committed Feb 12, 2024
1 parent 879fca6 commit 739e104
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 42 deletions.
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Before making a release, all of these should be complete:
- [ ] Update version and download links in `README.md`, and screenshot if necessary
- [ ] CHANGELOG.md should be updated to include a list of all major changes since the last release
- [ ] Copy the entirety of these instructions onto a new issue and call it **QA and Release version \<VERSION\>**
- [ ] Check if [PyMuPDF#3137](https://github.com/pymupdf/PyMuPDF/pull/3137) has been merged and if so, unpin PyMuPDF in pyproject.toml
- [ ] Create a PGP-signed git tag for the version, e.g. for dangerzone `v0.1.0`, the is created with:

```
Expand Down
77 changes: 36 additions & 41 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ strip-ansi = "*"
pymupdf = "^1.23.6"

[tool.poetry.group.container.dependencies]
pymupdf = "^1.23.8"
pymupdf = "1.23.8"

[tool.isort]
profile = "black"
Expand Down

0 comments on commit 739e104

Please sign in to comment.