Skip to content

Commit

Permalink
Fix artifact names for tags
Browse files Browse the repository at this point in the history
In trying to build the 2.6.0 release the build failed because multiple
outputs for different targets were being generated with the same name.
  • Loading branch information
fragglet committed Oct 26, 2024
1 parent 274188d commit 47e5cee
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,10 @@ jobs:
VERSION=${VERSION/#sdl-sopwith-/}
else
VERSION=$(git rev-parse --short HEAD)
VERSION=git-$VERSION${{ matrix.config.suffix }}
VERSION=git-$VERSION
fi
echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
echo "SUFFIXED_VERSION=$VERSION${{ matrix.config.suffix }}" >> $GITHUB_OUTPUT
# Patch the version in configure.ac:
sed -i.old "s/\(AC_INIT([^,]*, \)\[[^]]*\], /\1[$VERSION], /" \
configure.ac
Expand Down Expand Up @@ -151,18 +152,18 @@ jobs:
uses: actions/upload-artifact@v4
with:
path: "pkg/win32/staging"
name: sdl-sopwith-${{steps.version.outputs.VERSION}}
name: sdl-sopwith-${{steps.version.outputs.SUFFIXED_VERSION}}

- name: Build package (macOS)
if: runner.os == 'macOS'
run: |
cd pkg/macos
make PACKAGE_VERSION=${{steps.version.outputs.VERSION}} \
make PACKAGE_VERSION=${{steps.version.outputs.SUFFIXED_VERSION}} \
PACKAGE_STRING="Sopwith build ${{steps.version.outputs.VERSION}}"
- name: Upload build (macOS)
if: runner.os == 'macOS'
uses: actions/upload-artifact@v4
with:
path: "pkg/macos/sdl-sopwith-${{steps.version.outputs.VERSION}}.dmg"
name: sdl-sopwith-${{steps.version.outputs.VERSION}}
path: "pkg/macos/sdl-sopwith-${{steps.version.outputs.SUFFIXED_VERSION}}.dmg"
name: sdl-sopwith-${{steps.version.outputs.SUFFIXED_VERSION}}

0 comments on commit 47e5cee

Please sign in to comment.