chore(release): merge set of changes for v2.4.0 #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com>
fix: broken README.md link
* Allow hf dataset id to be loaded by training_data_path Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com> * update README Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com> * minor changes Signed-off-by: Abhishek <maurya.abhishek@ibm.com> --------- Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com> Signed-off-by: Abhishek <maurya.abhishek@ibm.com> Co-authored-by: Abhishek <maurya.abhishek@ibm.com>
* feat: accelerated MoE dataclass and init Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: author's note Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * feat: accelerated moe in acceleration framework Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * feat: accelerated moe to sft_trainer Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * feat: fmt, testing Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: rename accelerated moe to fast moe Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * test: add testing for scatter moe on accel framework Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: model, dtype, assertions Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: post init check removed from FastMoe, experimental set to True Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: if non-iterable nested dataclass, still initialize Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * test: add failing test for wrong ep_degree Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: actually expect failure Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * test: make sure fast moe doesn't work with non-moe model Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: regex of new test Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * comment: explain iterable unpacking Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * docs: fast MOE in README Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * docs: Add note for post-processing Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: Dockerfile Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * test: fix params Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: file path Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: expand on docs, remove from Dockerfile, move iterable data to else statement Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * lint Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: spelling Signed-off-by: Will Johnson <mwjohnson728@gmail.com> --------- Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
…ate (#430) * fix: allow for padding free + pretraining Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com> * add data collator for padding free plugin scenario to be used for extended pretraining Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com> * fix: update value error Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com> * fix: delete images only when exists Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com> --------- Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com> Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com> Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com> Co-authored-by: Harikrishnan Balagopal <harikrishmenon@gmail.com> Co-authored-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>
#434) * fix: function name from requires_agumentation to requires_augmentation Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fix: file path Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fmt Signed-off-by: Will Johnson <mwjohnson728@gmail.com> --------- Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
willmj
requested review from
anhuong,
Ssukriti,
aluu317,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
|
This looks good, but could we wait 1 day to merge? Waiting to test something for PR #422 and see if I can get it merged soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release 2.4.0!