Align stack on 16-bytes boundary #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahab-vahedi
approved these changes
May 8, 2024
The linker script for ARC-V aligns the stack on 4-bytes boundary and it leads to undefined behaviour while pushing arguments to the stack. It's necessary to align it on 16-bytes boundary since it's a maximum possible alignment for RISC-V targets according to RISC-V ABI. Signed-off-by: Yuriy Kolerov <kolerov93@gmail.com>
Signed-off-by: Yuriy Kolerov <kolerov93@gmail.com>
kolerov
force-pushed
the
arcvx-fix-alignment
branch
from
7847132 to
3e9c834
Compare
|
@shahab-vahedi I've also included a commit for fixing indentation in |
abrodkin
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linker script for ARC-V aligns the stack on 4-bytes boundary and it leads to undefined behaviour while pushing argument to the stack.
It's necessary to align it on 16-bytes boundary since it's a maximum possible alignment for RISC-V targets according to RISC-V ABI.