Skip to content

Commit

Permalink
Pass Github token to flakiness detection build (gradle#8967)
Browse files Browse the repository at this point in the history
The build to determine performance test flakiness wants to open Github
issues as well.
  • Loading branch information
wolfs authored Apr 8, 2019
1 parent 82466f4 commit 9270716
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ class PerformanceTestCoordinator(model: CIBuildModel, type: PerformanceTestType,
val rerunnerParameters = listOf(
"-PteamCityBuildId=%teamcity.build.id%",
"-PonlyPreviousFailedTestClasses=true",
"-PgithubToken=%github.ci.oauth.token%",
"-Dscan.tag.RERUN_TESTS")
runner("GRADLE_RERUNNER", "tagBuild distributed${type.taskId}s", rerunnerParameters.joinToString(" "), ExecutionMode.RUN_ON_FAILURE)
} else {
Expand Down
2 changes: 1 addition & 1 deletion .teamcity/common/performance-test-extensions.kt
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ fun performanceTestCommandLine(task: String, baselines: String, extraParameters:
)

fun distributedPerformanceTestParameters(workerId: String = "Gradle_Check_IndividualPerformanceScenarioWorkersLinux") = listOf(
"-Porg.gradle.performance.buildTypeId=${workerId} -Porg.gradle.performance.workerTestTaskName=fullPerformanceTest -Porg.gradle.performance.coordinatorBuildId=%teamcity.build.id%"
"-Porg.gradle.performance.buildTypeId=${workerId} -Porg.gradle.performance.workerTestTaskName=fullPerformanceTest -Porg.gradle.performance.coordinatorBuildId=%teamcity.build.id% -PgithubToken=%github.ci.oauth.token%"
)

Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ class PerformanceTestBuildTypeTest {
"-Porg.gradle.performance.buildTypeId=Gradle_Check_IndividualPerformanceScenarioWorkersLinux",
"-Porg.gradle.performance.workerTestTaskName=fullPerformanceTest",
"-Porg.gradle.performance.coordinatorBuildId=%teamcity.build.id%",
"-PgithubToken=%github.ci.oauth.token%",
"\"-Dscan.tag.PerformanceTest\"",
"--build-cache",
"\"-Dgradle.cache.remote.url=%gradle.cache.remote.url%\"",
Expand All @@ -95,7 +96,6 @@ class PerformanceTestBuildTypeTest {
+ expectedRunnerParams
+ "-PteamCityBuildId=%teamcity.build.id%"
+ "-PonlyPreviousFailedTestClasses=true"
+ "-PgithubToken=%github.ci.oauth.token%"
+ "-Dscan.tag.RERUN_TESTS"
).joinToString(" "),
performanceTest.getGradleStep("GRADLE_RERUNNER").gradleParams
Expand Down

0 comments on commit 9270716

Please sign in to comment.