Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New packaging #88

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

New packaging #88

wants to merge 18 commits into from

Conversation

leolivier
Copy link

Modernized packaging using only build and github action

@leolivier
Copy link
Author

Hi, this PR fixes the incompatibility with Django 5.1 + allows verification of emails for existing inactive users without forms (inspired by previous PRs which contained bugs) and modernized the packaging.
There are a lot of files changed just because for the modernization of pacjackging, I had to move the verify_email folder inside a src folder. The number of really changed files is very low (4 I think)
The github workflow is also modified in order to publish the package on test.pypi.org instead of pypi on a simple push, while creating a release will deploy it on pypi.
Also, the connection to github is modernized using a token, so you have to create a token in github and store it in the project secrets

IMPORTANT! On this modernization topic, to check it worked and as I had no right to publish a new version on PyPi for the project, I had to change the project name in pyproject.toml and use django-email-validation instead of Django-Verify-Email (and you can test this package django-email-validation with version 2.0.4 to check it works).
So if this PR is accepted, the name must be changed back to the initial value before delivering...

@foo290
Copy link
Owner

foo290 commented Nov 3, 2024

Yoooo! thanks for all the changes and suggestions man! Lemme review these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants