screenshot: Forward to modality to access dialog #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgesStavracas
approved these changes
Jan 23, 2025
|
I sound a bit like a broken record right now, but we should add tests! This one requires a non-interactive screenshot request which shall result in the access backend getting the right data. |
Sodivad
force-pushed
the
screenshot-forward-modal
branch
2 times, most recently
from
683e186 to
3298737
Compare
swick
reviewed
Jan 24, 2025
Sodivad
force-pushed
the
screenshot-forward-modal
branch
from
3298737 to
25f5087
Compare
|
https://flatpak.github.io/xdg-desktop-portal/docs/building-and-running.html#testing helps you with enabling git hooks for the python checks/formatting |
swick
reviewed
Jan 24, 2025
|
Thanks for adding tests! |
Needed for testing uninteractive screenshots. This will call the access portal first called and afterwards the screenshot portal with the same request handle. Unexport the request after the access portal is done so the screenshot portal can export a request at the same path afterwards.
Sodivad
force-pushed
the
screenshot-forward-modal
branch
from
25f5087 to
59db9ab
Compare
Sodivad
force-pushed
the
screenshot-forward-modal
branch
from
59db9ab to
ce66423
Compare
swick
reviewed
Jan 27, 2025
|
Alright, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.