Remove C based integration tests #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swick
force-pushed
the
wip/pytest-remove-c-tests
branch
8 times, most recently
from
a7329e1 to
ca49bdb
Compare
swick
force-pushed
the
wip/pytest-remove-c-tests
branch
2 times, most recently
from
01d4cb7 to
fb99dac
Compare
swick
force-pushed
the
wip/pytest-remove-c-tests
branch
2 times, most recently
from
09c7564 to
e8fdde9
Compare
|
This one is ready for review. It depends on #1594 (the document portal tests that I seem to have missed). |
whot
approved these changes
Jan 29, 2025
swick
force-pushed
the
wip/pytest-remove-c-tests
branch
2 times, most recently
from
a1675bc to
8a81cb2
Compare
|
The python changes here already made it into the main branch. I just forgot to rebase this PR. Created a PR with the issues you spotted: #1610 |
|
There's a file conflict with this PR |
Instead of seperating them on the fact that some are C and some are python, seperate them by what kind of tests they are. In this case, all C tests are unit tests and all pytest tests are integration tests.
swick
force-pushed
the
wip/pytest-remove-c-tests
branch
from
8a81cb2 to
35b5822
Compare
|
Rebased and renamed the test suite from |
GeorgesStavracas
approved these changes
Feb 4, 2025
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes
#1523
#1524
#1525
This is a draft because we should probably keep the C tests around for a bit and make sure the python tests are working as they should. Couldn't resist deleting so much code though...