Skip to content

Commit

Permalink
Merge pull request #38 from fivetran/bugfix/remove_null_tests
Browse files Browse the repository at this point in the history
remove null tests for person_id for models built from event based grains
  • Loading branch information
fivetran-reneeli authored Mar 4, 2024
2 parents 1ba17b7 + c9531ff commit 1bf9752
Show file tree
Hide file tree
Showing 10 changed files with 28 additions and 13 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/auto-release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: 'auto release'
on:
pull_request:
types:
- closed
branches:
- main

jobs:
call-workflow-passing-data:
if: github.event.pull_request.merged
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main
secrets: inherit
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# dbt_klaviyo v0.7.2
[PR #38](https://github.com/fivetran/dbt_klaviyo/pull/38) includes the following updates:

## Bug Fixes
- Removes `not_null` tests for `person_id` from `int_klaviyo__person_metrics` and `klaviyo__person_campaign_flow`. This is because Klaviyo can record events with deactivated profiles, resulting in null `person_id`s. Therefore models built off of tables with event-based grains may have null `person_id`s.

# dbt_klaviyo v0.7.1

## Dependency Updates
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'klaviyo'
version: '0.7.1'
version: '0.7.2'
config-version: 2
require-dbt-version: [">=1.3.0", "<2.0.0"]
vars:
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'klaviyo_integration_tests'
version: '0.7.1'
version: '0.7.2'
config-version: 2
profile: 'integration_tests'

Expand Down Expand Up @@ -75,4 +75,4 @@ seeds:
+column_types:
PHONE_NUMBER: "{{ 'string' if target.type in ('bigquery', 'spark', 'databricks') else 'varchar' }}"
flow:
+quote_columns: "{{ true if target.type == 'redshift' else false }}"
+quote_columns: "{{ true if target.type == 'redshift' else false }}"
2 changes: 0 additions & 2 deletions models/intermediate/int_klaviyo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ models:
columns:
- name: person_id
description: Unique ID of the person.
tests:
- not_null
- name: count_total_campaigns
description: Count of the number of campaigns this person has interacted with.
- name: count_total_flows
Expand Down
4 changes: 1 addition & 3 deletions models/klaviyo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,7 @@ models:
- source_relation
columns:
- name: person_id
description: Foreign key referencing the PERSON who interacted with the flow/message.
tests:
- not_null
description: Foreign key referencing the PERSON who interacted with the flow/message.
- name: last_touch_campaign_id
description: Foreign key referencing the CAMPAIGN attributed with these metrics (by the package's attribution model).
- name: last_touch_flow_id
Expand Down

0 comments on commit 1bf9752

Please sign in to comment.