General hypercube

[indiamai]

Builds on #68 in a way compatible with fuse development.

[pbrubeck]

Looks good in general. Could the UFCHypercube be a class on its own?

[indiamai]

Looks good in general. Could the UFCHypercube be a class on its own?

Good shout, have modified to have this be the case

[pbrubeck]

I am happy to merge this PR at this point, if you are also happy with that. Arguably this does not need new tests, as it is just refactoring.

[pbrubeck]

We need to run firedrake CI, of course

[indiamai]

We need to run firedrake CI, of course

How do you typically do that for a fiat only change? open a firedrake branch/pull request and just change the ci to run on this branch?

[pbrubeck]

How do you typically do that for a fiat only change? open a firedrake branch/pull request and just change the ci to run on this branch?

Correct, in the firedrake branch you add this to .github/workflows/build.yml before line ~88 firedrake-clean

pip install "fenics-fiat @ git+https://github.com/firedrakeproject/fiat.git@your/branch/name"

[indiamai]

How do you typically do that for a fiat only change? open a firedrake branch/pull request and just change the ci to run on this branch?

Correct, in the firedrake branch you add this to .github/workflows/build.yml before line ~88 firedrake-clean

pip install "fenics-fiat @ git+https://github.com/firedrakeproject/fiat.git@your/branch/name"

Great thanks i'll set that up.

[indiamai]

Firedrake tests all passing here firedrakeproject/firedrake#4124

[pbrubeck]

We would have to rerun the tests. It seems crucial to tell pip to ignore the original installation by passing -I, so the right command is

pip install -I "fenics-fiat @ git+https://github.com/firedrakeproject/fiat.git@your/branch/name"

[pbrubeck]

We should add a test for the previous commit

[indiamai]

We should add a test for the previous commit

Some FIAT tests added and all firedrake tests now passing

[connorjward]

I don't understand the code so these are just style points!

Done