-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Make search usable via keyboard (CTRL + K) #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Have to check the macOS behaviour, it doesn't work with the COMMAND key on macOS EDIT: Fixed |
8483025
to
6d7de2c
Compare
Is it that common to open search via CTRL + K (i didnt know it)? Some other websites (like github.com itself) uses |
6d7de2c
to
857e35f
Compare
At least all common frontend frameworks use it on their websites: On GitHub, CTRL + K also works for the search. CTRL + K is usually the shortcut for omnibox, i.e., using the search bar of the browser of the page. It got common to overwrite the shortcut to implement a custom search functionality. |
On these websites, it works from every page; we only have the search on home. I don't want to block the feature, but I wonder if it adds much value to our website. Another question: is this shortcut also supported by the A11Y community? Is it also supported by screen readers, or are there other shortcuts here? |
It does. You can navigate on the page via keyboard more easily. My usual workflow (that I use for other pages as well): Open the website via the URL, use CTRL + K to search and navigate to the target page. But nevertheless, page search on the whole website would be even better and I already created #120 for it.
Nothing that I have knowledge about, but ChatGPT summarized it as:
I'd argue that it improves accessibility since it's easier to navigate via keyboard. |
Let users open the search via the CTRL + K keyboard shortcut.