Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility Issue Detected with Python 3.11 and aws lambda #73

Merged
merged 4 commits into from
May 10, 2024
Merged

Compatibility Issue Detected with Python 3.11 and aws lambda #73

merged 4 commits into from
May 10, 2024

Conversation

amarnathcls
Copy link
Contributor

Made below changes

  1. AS older version of pytest and pytest-cov are not supported with latest versions of python updated their versions in requirements.text file.
  2. As ThreadPool of multiprocessing library not supported by aws lambda used ThreadPoolExecutor of concurrent.futures

sethk4783
sethk4783 requested changes May 9, 2024
View reviewed changes
filestack/uploads/intelligent_ingestion.py Outdated
import hashlib
import logging
import functools
import threading
from urllib3.util.retry import Retry
from multiprocessing.pool import ThreadPool
# from multiprocessing.pool import ThreadPool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code

filestack/uploads/multipart.py Outdated Show resolved Hide resolved
sethk4783
sethk4783 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@sethk4783 sethk4783 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemanth-3 hemanth-3 merged commit cb0c3d5 into filestack:develop May 10, 2024
1 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethk4783 sethk4783 sethk4783 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amarnathcls @sethk4783 @hemanth-3