Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/publish as package #1239

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Chore/publish as package #1239

wants to merge 13 commits into from

Conversation

sergiocarracedo
Copy link
Collaborator

@sergiocarracedo sergiocarracedo commented Feb 25, 2025 •
edited
Loading

Description

  • chore: Add husky to run precommit and commit-msg hooks
  • chore: Add conventional commits
  • chore: GH Action workflow to build and publish alpha versions after a commit to a PR (we only we will the 3 lastest alpha versions of each PR)
  • chore: GH Action workflow to Bump version and change log generation based in conventional commits using release-please
  • chore: GH Action workflow to Publish to build and publish the package to github's npm registry after any release

IMPORTANT: We (or the one in charge) should add a check in the monorepo to only allow to merge if factorial is using an stable version of factorial-one to avoid issues with the alpha/experimental versions

@sergiocarracedo sergiocarracedo force-pushed the chore/publish-as-package branch from 7f45d4b to 9c72c0d Compare February 25, 2025 16:05
@sergiocarracedo
Copy link
Collaborator Author

build

@sergiocarracedo sergiocarracedo force-pushed the chore/publish-as-package branch 2 times, most recently from ba5568f to b371ba0 Compare February 25, 2025 16:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

🔍 Visual review for your branch is published 🔍

Here are the links to:

@sergiocarracedo sergiocarracedo force-pushed the chore/publish-as-package branch 19 times, most recently from 3d456b8 to f0f57ac Compare February 26, 2025 08:58
@sergiocarracedo sergiocarracedo force-pushed the chore/publish-as-package branch 4 times, most recently from 663988b to f428916 Compare February 27, 2025 12:26
@sergiocarracedo sergiocarracedo force-pushed the chore/publish-as-package branch 11 times, most recently from d848375 to 8f6b39a Compare February 27, 2025 15:17
@github-actions @sergiocarracedo
chore(chore/publish-as-package): release 1.0.0 (#1274)
fd97446 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sergiocarracedo sergiocarracedo force-pushed the chore/publish-as-package branch 5 times, most recently from b6013b5 to ada0528 Compare February 27, 2025 16:08
@sergiocarracedo sergiocarracedo marked this pull request as ready for review February 27, 2025 16:08
@sergiocarracedo sergiocarracedo requested a review from a team as a code owner February 27, 2025 16:08
@github-actions @sergiocarracedo
chore(chore/publish-as-package): release 1.0.0 (#1279)
b4480a2 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sergiocarracedo sergiocarracedo force-pushed the chore/publish-as-package branch from ada0528 to b4480a2 Compare February 27, 2025 16:15
eliseo-juan
eliseo-juan approved these changes Feb 27, 2025
View reviewed changes
Copy link

@eliseo-juan eliseo-juan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job mate! I find this super valuable

docs/index.md

`factorial-one` is a set of component, hooks, utilities used as foundations for the factorial's app

- [Getting started](./getting-started.md)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel proud of this documentation

@github-actions @sergiocarracedo
chore(chore/publish-as-package): release 1.0.0 (#1279)
2313a2d 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sergiocarracedo sergiocarracedo force-pushed the chore/publish-as-package branch from a683046 to 2313a2d Compare February 28, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliseo-juan eliseo-juan eliseo-juan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiocarracedo @eliseo-juan