Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: StarkProof is not always the last element in a serialization buffer #236

Merged

Conversation

hackaugusto
Copy link
Contributor

This prevents other data structure to be serialized in the same buffer, which happen naturally for structs with additional field elements.

…buffer

This prevents other datastructure to be serialized in the same buffer,
which happen naturally for structs with additional field elements.
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! Looks good.

@irakliyk irakliyk merged commit d0cbd0b into facebook:main Dec 18, 2023
9 checks passed
@hackaugusto hackaugusto deleted the hacka-bugfix-serialization-stark-proof branch December 18, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants