jest to vitest

[Smrtnyk]

proposed here #10417 (comment)

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[Smrtnyk]

I feel like this ceremony with jest-snapshot package could be circumvented with https://vitest.dev/guide/snapshot#custom-serializer
but I didn't dig deep what exactly this is all about
i assume for more simple snapshots or something

I will leave it for some other time

[asturur]

I think is to add 'toMatchRoundedMatrix' maybe we can avoid to use that custom matcher or just have a function in that case that does what it has to do

[asturur]

My first impression is that the api changes are minimal ( just mock checks a little bit ).
I ll have a read of how vitest runs in a browser and see if is worth to have some of those running in a browser too.

[asturur]

those needs to stay in a separate PR, could also be the reason why your build is failing

[Smrtnyk]

those needs to stay in a separate PR, could also be the reason why your build is failing

build failed most probably because I removed @types/jsdom
https://github.com/fabricjs/fabric.js/pull/10420/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L87
because I thought those were only used for tests, but they are actually needed for building the prod code
I will bring those types back
Regarding dropping the jsdom update here I am not sure about that, I reverted the old jsdom version and vitest tests didn't work
seems like it relies on newer jsdom
That being said, vitest and this PR rely on node at least being 18 and newer jsdom, so maybe this PR should land after your PR
#10417
And then we just rebase this PR when it is merged

After we land this (if we land this) I can help you migrate some of those QUnit tests to vitest
I am not that good with maths so can't really help you with fabric src code, but I have a bit of experience with testing and tooling so I can help you with that

[Smrtnyk]

My first impression is that the api changes are minimal ( just mock checks a little bit ). I ll have a read of how vitest runs in a browser and see if is worth to have some of those running in a browser too.

I am using browser mode heavily in my vue project, because I can test my components in real environment with real rendering and screenshots.
The only downside is that you can't use breakpoints and debugger from node, you have to start the ui and headed browser then in the ui put a breakpoint in the browser instance which is a bit cumbersome

[Smrtnyk]

@asturur could you please rerun the build? to see if it is fixed now