Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Response에서 DTO로 수정, Mapper 매서드 수정 #7

Merged
merged 1 commit into from
Feb 17, 2025
Merged

feat: Response에서 DTO로 수정, Mapper 매서드 수정 #7

merged 1 commit into from
Feb 17, 2025

Conversation

gominnam
Copy link
Collaborator

📌 변경 사항

  • JacksonConfig 삭제
  • ResponseEntity -> EntityDTO 수정

🤔 고민한 점

  • Get events/{id} 요청에서 N+1 문제가 발생하여 Fetch Join으로 변경하였습니다.
  • JacksonConfig을 사용하는 것 대신에 EventDTO의 of 메소드에서 boolean 값을 받아서 Showtime 여부를 검증하도록 수정하였습니다.

@gominnam gominnam requested a review from f-lab-troy February 15, 2025 05:51
@gominnam gominnam merged commit e0462df into feature/3-ticket-api-event Feb 17, 2025
1 check passed
@gominnam gominnam deleted the feature/3-ticket-api-event-dto branch February 17, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-troy f-lab-troy f-lab-troy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gominnam @f-lab-troy