Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API 성능 개선, 예약 API Exception 처리 추가, 모니터링 설정파일 추가 #15

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

gominnam
Copy link
Collaborator

📌 변경 사항

  • Spring @Cacheable 를 Controller에 적용
  • NOWAIT 의 예외 처리 수정

🤔 고민한 점

  • Ngrinder TPS 성능 개선을 위하여 @Cacheable를 적용하였습니다. (약 TPS 2배 증가)
  • Ngrinder 예매 API 테스트중 0.5 % 확률로 Error 가 발생했는데 NOWAIT 으로 발생한 예외를 제대로 처리하지 못하여 Error가 발생하지 않도록 수정하였습니다.
  • 예매 요청은 Update를 수반하는데 이런 경우에 @Cacheable 을 사용해도 괜찮을지 혹은 어떻게 개선해야할지 고민중입니다.

@gominnam gominnam requested a review from f-lab-troy February 20, 2025 09:44
Copy link

@f-lab-troy f-lab-troy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예매 요청은 Update를 수반하는데 이런 경우에 Cacheable 을 사용해도 괜찮을지 혹은 어떻게 개선해야할지 고민중입니다.

업데이트시 Cacheable을 사용했을때 발생할 수 있는 문제점이 있는지 조사해보는걸 추천드립니다.

ports:
- "3000:3000"
environment:
- GF_SECURITY_ADMIN_PASSWORD=admin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

password노출은 피하는게 좋습니다.

@gominnam gominnam merged commit 25663ad into develop Feb 21, 2025
1 check passed
@gominnam gominnam deleted the feature/13-performance-improve-cacheable branch February 21, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants