feat: 프로메테우스, 그라파나 설정 yml 파일 추가 #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Event 엔티티와 EventStatus Enum 추가 - EventService와 EventServiceImpl 구현 - EventServiceImpl 단위 테스트 추가
feat: Event 엔티티와 서비스 구현 추가
- Event 엔티티 모델링 수정 - EventResponse DTO 클래스 추가 - EventNotFoundException 예외클래스 추가 - EventServiceImpl에서 getEventById(..) 메서드에 Null일 경우 예외처리
feat: Event 도메인 DTO와 예외 클래스 추가 Event 엔티티 수정
- 직렬화 하기위한 JacksonConfig 추가 - ShowtimeResponse DTO 추가
feat: ShowtimeResponse 객체와 직렬화 Config 추가
feat: 공통 GlobalExceptionHandler와 BaseTimeEntity 추가
feat: Response에서 DTO로 수정, Mapper 매서드 수정
…-tests feat: Event 단위 테스트 추가
…vice feat: TickerService 예매, 테스트 코드 추가
|
멘토님 다시 확인해보니 files changes 갯수가 45개나 돼 있어서 코멘트 남깁니다.. 크게 변동사항은 없고 docker-compose.yml, prometheus.yml 설정파일만 변동됐습니다. |
잘못 올려진 pr은 취소해주시고 원하는 파일만 포함한 새 pr을 요청해주시길 바랍니다. |
|
넵 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 변경 사항
🤔 고민하고 있는 것