feat: TickerService 예매, 테스트 코드 추가 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-troy
approved these changes
Feb 18, 2025
| throw new TicketsNotAvailableException(); | ||
| } | ||
|
|
||
| Duration expirationTime = Duration.ofMinutes(5); |
|
|
||
| @Override | ||
| @Transactional | ||
| public void reserveTickets(TicketDTO ticketDTO) { |
There was a problem hiding this comment.
동시성 문제를 발생 시킨 후에 문제 해결을 하여 왜 문제가 발생하였고 어떻게 해결 됐는지를 문서화 해두면 좋습니다
| @Override | ||
| @Transactional | ||
| public void reserveTickets(TicketDTO ticketDTO) { | ||
| try { |
There was a problem hiding this comment.
Ticket 검증로직과 reserve로직을 다른 메서드로 분리하면 어떤 장점이 있을지 고려해보면 좋습니다
|
|
||
| spring.datasource.url=jdbc:mysql://localhost:3306/safeticket_db | ||
| spring.datasource.username=root | ||
| spring.datasource.password=password |
There was a problem hiding this comment.
사용자 정보와 같이 보안상 예민한 정보를 노출하지 않는 방법을 고려해보시기 바랍니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 변경 사항
🤔 고민한 점
FOR UPDATE NOWAIT을 추가하여 대기하지 않고 바로 예외처리 발생시키도록 하였습니다.😅 실수한 부분