-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(observability/logs): add logging support to grafana #149
Open
edobry
wants to merge
19
commits into
ethpandaops:main
Choose a base branch
from
edobry:logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e91a7e0
to
3bf7f63
Compare
scharissis
approved these changes
Feb 18, 2025
5de34db
to
49ae104
Compare
scharissis
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on the previously-added Grafana support to add log collection by:
promtail_params
andloki_params
sections to the top-levelobservability
parameter sectionenable_k8s_features
parameter to theobservability
sectionpromtail
instance and Loki serverThe major caveat to this work is that due to Kurtosis limitations, log collection is only supported when running on the Kubernetes Kurtosis backend, as to allow
promtail
to collect logs from all enclave services, it must be deployed with Helm. To this end, theobservability.enable_k8s_features
parameter must be explicitly set by the user, as Kurtosis does not provide a method to detect which backend the Starlark program will be executed against.Note that in order to work around Kurtosis limitations (Kurtosis runs pods using the namespace's default
ServiceAccount
, which is not typically able to modify cluster-level resources, such asClusterRoles
, as thepromtail
Helm chart requires), this PR also creates thens-authz
Helm chart, which must be installed to the Kubernetes cluster serving as the Kurtosis backend using the following command:This PR also updates the package README to document the observability stack, and adds a
justfile
to enable easy access to Grafana:This PR has been tested and successfully configures log collection, exposing logs in Grafana:
