-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: set GOTOOLCHAIN var for report validation #17734
Conversation
Looks like I didn't keep up with latest Golang features. Don't know toolchain feature enough to make long term decision yet, however short term would be good to be consistent. The choice is either I think until we decide to remove |
Agreed to use |
Set GOTOOLCHAIN directive in order to successfully run tests from root. Else, go will try and download a family of releases (of the form 1.x), which are not published binaries. Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2632b82
to
856847d
Compare
Hey all, getting back to this PR @jmhbnz that's a good point. I've made the change that uses the Also, as next steps, we could do what Kubernetes does: https://github.com/kubernetes/community/blob/aea3ba11fc4dee0ae21f20c7412c732b79c666eb/contributors/devel/development.md#building-kubernetes-using-a-specific-version-of-go Maybe have a way of setting the |
Please feel free to merge this PR if any maintainer wants. But we need to revisit the go version management. Please read #17857 |
Right, want to merge as the makefile command apparently doesn't work for @MadhavJivrajani ref #17733 (comment) |
Set GOTOOLCHAIN directive in order to successfully run tests
from root. Else, go will try and download a family of releases
(of the form 1.x), which are not published binaries.
Ref: #17733 (comment)