runtime: hard code materialize-bigquery in ser_policy
#1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigQuery actually has a limit of 20MiB on an individual row that can be returned via its Query API. Although we can store a row with a `flow_document` that large, we then can't read it back out using the conventional query mechanism the materialization connector currently uses. This adds `materialize-bigquery` to the list of connectors that use `ser_policy`, which should generally reduce how often we store rows that are excessively large.
williamhbaker
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BigQuery actually has a limit of 20MiB on an individual row that can be returned via its Query API. Although we can store a row with a
flow_documentthat large, we then can't read it back out using the conventional query mechanism the materialization connector currently uses.This adds
materialize-bigqueryto the list of connectors that useser_policy, which should generally reduce how often we store rows that are excessively large.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is