Skip to content

Commit

Permalink
source-sqlserver: Watermarks config is deprecated
Browse files Browse the repository at this point in the history
Changes the wording of the watermarks table advanced config
property to tell users that it's deprecated for new captures.
  • Loading branch information
willdonnelly committed Feb 20, 2025
1 parent 81031b5 commit a2dc942
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions source-sqlserver/.snapshots/TestGeneric-SpecResponse
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@
},
"advanced": {
"properties": {
"watermarksTable": {
"type": "string",
"description": "The name of the table used for watermark writes during backfills. Must be fully-qualified in '\u003cschema\u003e.\u003ctable\u003e' form.",
"default": "dbo.flow_watermarks"
},
"skip_backfills": {
"type": "string",
"title": "Skip Backfills",
Expand Down Expand Up @@ -84,6 +79,11 @@
"type": "string",
"title": "Feature Flags",
"description": "This property is intended for Estuary internal use. You should only modify this field as directed by Estuary support."
},
"watermarksTable": {
"type": "string",
"description": "This property is deprecated for new captures as they will no longer use watermark writes by default. The name of the table used for watermark writes during backfills. Must be fully-qualified in '\u003cschema\u003e.\u003ctable\u003e' form.",
"default": "dbo.flow_watermarks"
}
},
"additionalProperties": false,
Expand Down
2 changes: 1 addition & 1 deletion source-sqlserver/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,14 @@ type Config struct {
}

type advancedConfig struct {
WatermarksTable string `json:"watermarksTable,omitempty" jsonschema:"default=dbo.flow_watermarks,description=The name of the table used for watermark writes during backfills. Must be fully-qualified in '<schema>.<table>' form."`
SkipBackfills string `json:"skip_backfills,omitempty" jsonschema:"title=Skip Backfills,description=A comma-separated list of fully-qualified table names which should not be backfilled."`
BackfillChunkSize int `json:"backfill_chunk_size,omitempty" jsonschema:"title=Backfill Chunk Size,default=50000,description=The number of rows which should be fetched from the database in a single backfill query."`
AutomaticChangeTableCleanup bool `json:"change_table_cleanup,omitempty" jsonschema:"title=Automatic Change Table Cleanup,default=false,description=When set the connector will delete CDC change table entries as soon as they are persisted into Flow. Requires DBO permissions to use."`
AutomaticCaptureInstances bool `json:"capture_instance_management,omitempty" jsonschema:"title=Automatic Capture Instance Management,default=false,description=When set the connector will respond to alterations of captured tables by automatically creating updated capture instances and deleting the old ones. Requires DBO permissions to use."`
Filegroup string `json:"filegroup,omitempty" jsonschema:"title=CDC Instance Filegroup,description=When set the connector will create new CDC instances with the specified 'filegroup_name' argument. Has no effect if CDC instances are managed manually."`
RoleName string `json:"role_name,omitempty" jsonschema:"title=CDC Instance Access Role,description=When set the connector will create new CDC instances with the specified 'role_name' argument as the gating role. When unset the capture user name is used as the 'role_name' instead. Has no effect if CDC instances are managed manually."`
FeatureFlags string `json:"feature_flags,omitempty" jsonschema:"title=Feature Flags,description=This property is intended for Estuary internal use. You should only modify this field as directed by Estuary support."`
WatermarksTable string `json:"watermarksTable,omitempty" jsonschema:"default=dbo.flow_watermarks,description=This property is deprecated for new captures as they will no longer use watermark writes by default. The name of the table used for watermark writes during backfills. Must be fully-qualified in '<schema>.<table>' form."`
}

type tunnelConfig struct {
Expand Down

0 comments on commit a2dc942

Please sign in to comment.