Migrate llvm_asm! to asm! #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirhcel
force-pushed
the
migrate-llvm-asm-to-asm
branch
2 times, most recently
from
566a7be to
6461cd6
Compare
|
I did not know about how to build |
sirhcel
force-pushed
the
migrate-llvm-asm-to-asm
branch
from
6461cd6 to
6bd2459
Compare
The macro llvm_asm! finally got removed as 'asm!' got stabilized in nightly. See rust-lang/rust#70173 (comment) and this gets shipped starting with nightly 2022-01-17. According to https://users.rust-lang.org/t/volatile-option-in-new-asm-macro/44289/2 assembly is volatile by default with asm!.
sirhcel
force-pushed
the
migrate-llvm-asm-to-asm
branch
from
6bd2459 to
a840865
Compare
sirhcel
added a commit
to sirhcel/esp-idf-hal
that referenced
this pull request
Jan 24, 2022
This avoids a compiler warning on single-core targets which do not perform an actual check. This fixes esp-rs#36.
usbalbin
pushed a commit
to usbalbin/esp-idf-hal
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to rust-lang/rust#70173 (comment),
asm!got stabilized in nightly andllvm_asm!Migrating to
asm!makes this crate compile again with nightly 2022-01-17 for me. Thank you @jessebraham for pointing me to the issue above!