Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newalarm #340

Draft
wants to merge 45 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
84457af
updated checkRingTime
feiliuesmf Jun 17, 2021
14d1b9f
Merge branch 'develop' of https://github.com/esmf-org/esmf into newalarm
feiliuesmf Jul 1, 2021
8fefc23
Update alarm implementation and unit tests
feiliuesmf Jul 1, 2021
9bd03f2
Merge branch 'develop' of https://github.com/esmf-org/esmf into newalarm
feiliuesmf Jul 6, 2021
a6f1a2b
Fix ringTime reset when alarm is created
feiliuesmf Jul 19, 2021
391f735
Merge branch 'develop' of https://github.com/esmf-org/esmf into newalarm
feiliuesmf Jul 28, 2021
289bc08
Notify user with error message to clarify the cause of writeVTK falilure
feiliuesmf Jul 28, 2021
3e96719
Update ringTime and prevRingTime
feiliuesmf Aug 5, 2021
6706877
Merge branch 'develop' of https://github.com/esmf-org/esmf into newalarm
feiliuesmf Aug 5, 2021
44cc017
Add ringerIsOn as a part of isRinging check
feiliuesmf Aug 16, 2021
8659cae
update alarm ringing calculation
feiliuesmf Sep 13, 2021
a55a2a7
Merge branch 'develop' of https://github.com/esmf-org/esmf into newalarm
feiliuesmf Oct 13, 2021
8fddb32
New alarm implemention with updated tests and examples
feiliuesmf Apr 25, 2022
5a91b70
Merge branch 'develop' of https://github.com/esmf-org/esmf into newalarm
feiliuesmf Apr 28, 2022
c61e487
Fix CircleCI config
rsdunlapiv May 3, 2022
ab6e91f
Remove argument documentation in alarmget
feiliuesmf May 11, 2022
8cb9422
Clarify the ringtime argument retrieved by AlarmGet
feiliuesmf May 11, 2022
29f31e7
Update alarmCreate for the case ringTime is not specified; clarify th…
feiliuesmf Jun 6, 2022
7d3fe74
Merge branch 'develop' into newalarm
rsdunlapiv Jul 29, 2022
b93fb15
Set versioning for 8.4.0 release.
theurich Oct 24, 2022
ed4d9d6
Add 'Bill Sacks' to the author list.
theurich Oct 24, 2022
9935617
Merge branch 'release/8.4.0' into main
theurich Oct 24, 2022
cc2575e
Set versioning for 8.5.0 release.
theurich Jul 25, 2023
5d4f093
Merge branch 'release/8.5.0' into main
theurich Jul 25, 2023
ec5f186
Merge branch 'release/8.6.0' into main
theurich Nov 9, 2023
54fd99e
Merge tag 'v8.5.0' into newalarm
billsacks Dec 26, 2024
ca0dbc8
Change "newalarm" reference to "alarm"
billsacks Dec 26, 2024
7bfe6e4
Merge tag 'v8.6.0' into newalarm
billsacks Dec 26, 2024
4dfa122
Merge tag 'v8.7.0b08' into newalarm
billsacks Dec 26, 2024
870904e
Add missing !EX_UTest labels
billsacks Dec 26, 2024
65b1e78
Clean up Forward and Reverse alarm tests and make them more rigorous
billsacks Dec 27, 2024
fc8bbef
Clean up ForwardReverseAlarm tests and make them more rigorous
billsacks Dec 28, 2024
41c61d1
Clean up Test_ClockSet and call it with both forward and reverse clocks
billsacks Dec 28, 2024
635c111
Remove some "#if 1" conditionals
billsacks Dec 28, 2024
ecec444
Improve rigor of Test_ReverseAlarms
billsacks Dec 29, 2024
f601b70
Clean up Test_AlarmHang and make it more robust
billsacks Jan 2, 2025
7a45c0d
Clean up Test_AlarmAdvRewind and make it actually test things rigorously
billsacks Jan 2, 2025
4c8a904
Remove Test_RevAlarmSticky
billsacks Jan 3, 2025
0b6f73e
Minor cleanup of Test_GetPrevRingTime
billsacks Jan 3, 2025
e40712f
Fix indentation
billsacks Jan 3, 2025
c127912
Remove duplicate line of code
billsacks Jan 7, 2025
b8d72a9
Remove unused checkTurnOn function
billsacks Jan 7, 2025
a55cffa
Remove no-longer-referenced ringingOnCurrTimeStep
billsacks Jan 7, 2025
cdb1c87
Extend tests with alarm interval not a multiple of time step
billsacks Jan 16, 2025
fd3a249
Add a sticky alarm to ForwardAlarm_Test4
billsacks Jan 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions src/Infrastructure/TimeMgr/doc/Alarm_rest.tex
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,11 @@
This constant is defined in both Fortran and C++ with a \#define for ease
of modification.

\item {\bf Sticky alarm end times in reverse} For sticky alarms, there is
an implicit limitation that in order to properly reverse timestep through a
ring end time, that time must have already been traversed in the forward
direction. This is due to the fact that the Time Manager cannot predict
when user code will call {\tt ESMF\_AlarmRingerOff()}. An error message
will be logged when this limitation is not satisfied.
\item {\bf Alarm ringInterval } The alarm ring interval must be greater
than or equal to clock time step. This is consistent with physical clock and
alarm behavior.

\item {\bf Sticky alarm ring interval in reverse}
\begin{sloppypar}
For repeating sticky alarms,
it is currently assumed that the ringInterval is constant, so that only the
time of the last call to {\tt ESMF\_AlarmRingerOff()} is saved. In
{\tt ESMF\_DIRECTION\_REVERSE}, this information is used to turn sticky alarms
back on. In a future release, ringIntervals will be allowed to be variable,
by saving alarm state at every timestep.
\end{sloppypar}
\item {\bf Alarm ring time} An alarm will only ring if its ring time matches
exactly the clock's current time.

\end{enumerate}
Loading
Loading