ct: Remove usage of deprecated ct_slave in tests #9560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only change here I'm a bit unsure about is the `cth_auto_clean` suite, it is unclear to me why the application master is not started in `init_per_suite` already, as I can't find any call to start an app inbetween.
Since peer is way less talkative on the console, trim the remaining logs too, such that we can use e.g. `cte_track` for clean console output.
CT Test Results 2 files 57 suites 1h 12m 28s ⏱️ Results for commit ba75f33. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits update the
common_testtest suite to:ct_slaveandslavemodules in tests (with the exception of thect_slavetests itself, and sometest_servertests fortest_server:start_node)ct:paltoct:login most top-level test suites (except forct_log_SUITE, which explicitly wants to test them), since the stdout ofpeernodes won't be shown on the main test nodes & IMO make sense to contain to the HTML logscte_trackevent handler in tests for both local and GitHub-based runsThe second and third commit are of course a bit opinionated, so I'm happy to drop them (and possibly make
peerlog to our stdout) if wanted.