Enable dynamic modules & high level doc #38295
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
| -------------------------- | ||
|
|
||
| We have a dedicated repository for the dynamic module examples to help you get started. | ||
| The repository is available at `envoyproxy/dynamic-modules-examples <https://github.com/envoyproxy/envoyproxy/dynamic-modules-examples>`_ |
There was a problem hiding this comment.
note: I chatted with @.phlax offline that using the existing examples repository is not suitable for dynamic modules due to some reasons. The biggest reason is the strict version compatibility requirement makes it impossible to make it part of the CI. For example, when the ABI file gets modified, then the example verify CI will fail indefinitely.
The other reason i personally feel is we want to show users that they don't need the envoy specific build settings like bazel etc to build modules and instead they can simply use the standard language tooling (at this point cargo/rustc). The new repository comes with bazel just in case to be alined with Envoy main repo settings, but will also be used as a standalone example repo with native toolchains.
The repository is here https://github.com/envoyproxy/dynamic-modules-examples - i will work on it after this gets merged and the build image becomes available
There was a problem hiding this comment.
| The repository is available at `envoyproxy/dynamic-modules-examples <https://github.com/envoyproxy/envoyproxy/dynamic-modules-examples>`_ | |
| The repository is available at `envoyproxy/dynamic-modules-examples <https://github.com/envoyproxy/dynamic-modules-examples>`_ |
|
/assign @phlax |
|
/retest |
|
/docs |
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/38295/docs/index.html The docs are (re-)rendered each time the CI |
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
docs: adds a release note about dynamic_modules This is a follow up on #38295 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
|
PR of the year already?! |
Commit Message: Enable dynamic modules & Add high level doc
Additional Description:
This adds a high level documentation of dynamic_modules feature
that has been developed over the last few months and has finally
become usable for users.
closes #2053
closes #24230
closes #32502
Risk Level: low
Testing: existing ones
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a