udp_proxy: fix crash during buffer watermarks callbacks #37689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ohad Vano <ohadvano@gmail.com>
Signed-off-by: Ohad Vano <ohadvano@gmail.com>
Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com>
|
Assigning udp_proxy codeowners to review. |
mattklein123
previously approved these changes
Dec 19, 2024
|
Sorry please merge main. /wait |
Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com>
mattklein123
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Description: In cases where writing upstream causes the buffer to go below low watermarks,
onBelowWriteBufferLowWatermarkcallback will be called, causing another write on the upstream codec, during an already existing write process. With nghttp2 based codec, this causes Envoy to crash. For oghttp2 based codec, it simply discards the new written payload. The fix is posting the consecutiveflushBufferoperation on the dispatcher rather than immediately calling it.Risk Level: low
Testing: unit tests
Docs Changes: changelog
Release Notes: none
Platform Specific Features: none