address missing coverage

Signed-off-by: William <wtzhang23@gmail.com>
envoyproxy · Feb 20, 2025 · cc819ab · cc819ab
1 parent 6ecc2db
commit cc819ab
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/source/extensions/filters/http/adaptive_concurrency/controller/gradient_controller.h b/source/extensions/filters/http/adaptive_concurrency/controller/gradient_controller.h
@@ -323,6 +323,9 @@ class DynamicGradientController : public ConcurrencyController {
 };
 using DynamicGradientControllerSharedPtr = std::shared_ptr<DynamicGradientController>;
 
+/**
+ * A concurrency controller similar to `DynamicGradientController`, except minRTT is fixed.
+ */
 class PinnedGradientController : public ConcurrencyController {
 public:
   PinnedGradientController(PinnedGradientControllerConfig config, Event::Dispatcher& dispatcher,

diff --git a/test/extensions/filters/http/adaptive_concurrency/controller/gradient_controller_test.cc b/test/extensions/filters/http/adaptive_concurrency/controller/gradient_controller_test.cc
@@ -949,6 +949,27 @@ min_concurrency: 7
   verifyMinRTTValue(min_rtt);
 }
 
+TEST_F(GradientControllerTest, PinnedMinRTTSamplePercentileProcessTest) {
+  const std::string yaml = R"EOF(
+sample_aggregate_percentile:
+  value: 50
+concurrency_limit_params:
+  max_concurrency_limit:
+  concurrency_update_interval: 0.1s
+min_rtt: 0.05s
+)EOF";
+
+  auto controller = makePinnedController(yaml);
+
+  tryForward(*controller, true);
+  tryForward(*controller, true);
+  tryForward(*controller, true);
+  tryForward(*controller, false);
+  controller->cancelLatencySample();
+  tryForward(*controller, true);
+  tryForward(*controller, false);
+}
+
 } // namespace
 } // namespace Controller
 } // namespace AdaptiveConcurrency