履修情報の記憶と更新、相手の授業も考慮した日程調整 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
uxiun
force-pushed
the
feature/db-courses-simple
branch
from
4e9857b to
8fdab99
Compare
|
現在の学期が正しく取得されるように直した。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ユーザ視点での変更の説明
履修情報CSVを毎回読み込ませる必要がなくなり、学期の変わり目など履修中の授業を更新したいときだけでよくなった。
自分だけでなく相手の履修している授業も考慮した空き時間の計算がされるようになった。
開発者視点での変更の説明
adjust/candidate.tsxのhandleSchedule関数で招待相手のidをもとに授業を取得し、その授業時間を算出して、findFreePeriods()に渡す忙しい時間帯periodsに含めたWeekViewに渡していたprops,courseをcoursePeriodsに変更して、重複して計算する無駄を省いた。イシュー番号・リンク
レビュー前のチェックリスト
DB に dummy data を入れて簡単に確認した