Fix create_meta function in cli.py #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix create_meta function
KennethEnevoldsen
approved these changes
Jun 13, 2024
|
Wonderful thanks for the PR |
|
@lbourdois Thanks for the PR, The tests are failing due to the |
|
Thanks for the tip @henilp105, it's been propagated |
henilp105
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Thanks @lbourdois , just run the make lint and then push a commit , so that it could be merged.
KennethEnevoldsen
merged commit af365b7
into
embeddings-benchmark:main
6 of 7 checks passed
|
Pushing and linting in main |
|
Sorry I've been off for the last few days. Glad you could manage without me 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I followed the instructions provided in https://github.com/embeddings-benchmark/mteb/blob/main/docs/adding_a_model.md.
It turns out that at step "3. Add the frontmatter to model repository", when copying the metadata generated in the README.md, Hugging Face returns the following error:
After some investigation, I realized that this was because "s" was missing for "metrics" as well as a "-" before the "type:" contained in "metrics".
By adding them, everything works locally. So I'm taking the liberty of opening this PR to avoid this problem for others.
Have a nice day :)