Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese translation #37

Merged
merged 4 commits into from
Apr 9, 2020
Merged

Japanese translation #37

merged 4 commits into from
Apr 9, 2020

Conversation

ndoll
Copy link
Contributor

@ndoll ndoll commented Apr 9, 2020

There might be a better term for Guaranteed Min, but the rest should be solid.

@DevSplash
Copy link
Contributor

Please update /src/i18n.js and /src/Localizer.jsx.

In /src/i18n.js, create an import statement for your language, importing the translation.json file you just created. Follow the pattern used by the existing statements.

In the same file (/src/i18n.js), add your language to the list of languages inside the resources object within the i18n.init() method, following the pattern of other declared languages, and using the same two-letter language tag you used for the folder name in the first step.

Lastly, to add your language to the manual language switcher on the page, make sure to edit the Localizer component at /src/Localizer.jsx. Add a tuple for your language to the languages array, with the first value being your two-letter language code and the second value being the name of your language, in your language.

@ndoll
Copy link
Contributor Author

ndoll commented Apr 9, 2020

Sorry about that, all done!

@mmarquez76
Copy link
Collaborator

mmarquez76 commented Apr 9, 2020

Small nitpick, but make sure to use the correct ISO 639-1 code for Japanese, which is ja.

There's a slight error in that you use the code jp, which is the code for country, Japan, but not for language, Japanese. We're trying to keep the standard to language codes, not country codes.

locales/jp/translation.json Outdated Show resolved Hide resolved
src/Localizer.jsx Outdated Show resolved Hide resolved
src/i18n.js Outdated Show resolved Hide resolved
@DevSplash
Copy link
Contributor

Small nitpick, but make sure to use the correct ISO 639-1 code for Japanese, which is jo.

There's a slight error in that you use the code jp, which is the code for Japan, but not for Japanese. We're trying to keep the standard to language codes, not country codes.

The Japanese language code seems to be ja instead of jo.

@mmarquez76
Copy link
Collaborator

Small nitpick, but make sure to use the correct ISO 639-1 code for Japanese, which is jo.
There's a slight error in that you use the code jp, which is the code for Japan, but not for Japanese. We're trying to keep the standard to language codes, not country codes.

The Japanese language code seems to be ja instead of jo.

Err, yeah, you're right about that. Been working on fixing the Korean translation at the same time (which is ko instead of kr) and mixed up the letters. I'll fix that, good catch.

@ndoll
Copy link
Contributor Author

ndoll commented Apr 9, 2020

Thanks for pointing that out, I'll make the changes now.

@elxris elxris merged commit 3bd65f0 into elxris:master Apr 9, 2020
@elxris
Copy link
Owner

elxris commented Apr 9, 2020

Thank you! #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants