Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowSwitcher: Don't use Gtk #1868

Merged
merged 8 commits into from
Feb 28, 2024
Merged

WindowSwitcher: Don't use Gtk #1868

merged 8 commits into from
Feb 28, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Feb 25, 2024 •
edited
Loading

Slowly going towards #1839

While we're here let clutter handle layouting and don't do it ourselves.

I'm not sure whether we need a border or something here. StyleContext.render_frame was called but in the CSS I didn't find any hints to a border or something similar? Also visually it seems to be the same? Although I'm not sure my eyes are good enough to make out a difference :)

@leolost2605 leolost2605 marked this pull request as ready for review February 25, 2024 01:04
@leolost2605 leolost2605 requested a review from a team February 25, 2024 01:04
lenemter
lenemter requested changes Feb 25, 2024
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is broken on my machine. It displays a transparent rectangle and a white rectangle in the top left corner of the screen and randomly crashes.

tintou
tintou previously approved these changes Feb 25, 2024
View reviewed changes
@leolost2605
Copy link
Member Author

Sorry I shuffled some things around and didn't test again 😅
Should be fixed now

@leolost2605 leolost2605 requested a review from lenemter February 25, 2024 12:23
lenemter

This comment was marked as resolved.

Sign in to view

@leolost2605 leolost2605 requested a review from lenemter February 25, 2024 16:51
@leolost2605
Copy link
Member Author

leolost2605 commented Feb 25, 2024 •
edited
Loading

Ok I found another crash I hope that was it 🤞

lenemter
lenemter approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't crash anymore and works as expected. Good job!

danirabbit
danirabbit approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming everything looks the same here to my eyes. I think render_frame is supposed to render all box shadows IIRC. There's a missing inner box shadow but this is also the case in master so LGTM 🚀

@leolost2605 leolost2605 merged commit 6cae827 into master Feb 28, 2024
4 checks passed
@leolost2605 leolost2605 deleted the leolost/window-switcher-no-gtk branch February 28, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintou tintou tintou approved these changes

@danirabbit danirabbit danirabbit approved these changes

@lenemter lenemter lenemter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leolost2605 @tintou @danirabbit @lenemter