Fix rounded background #1845
Merged
Fix rounded background #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes changing background going grey since removing setting clip bounds
danirabbit
approved these changes
Feb 8, 2024
leolost2605
added a commit
that referenced
this pull request
Feb 9, 2024
Fixes a regression from #1845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1841
Closes #1843
Ok I did some digging so here is what I found and what I think is happening:
When clip bounds aren't set the full texture size is used as clip bounds. But when the texture isn't loaded yet the size is seen as 0 so clip bounds are set to 0 and the whole texture is clipped away because clip bounds aren't updated when the texture is loaded.
Anyways regardless of whether that's actually what's happening this PR fixes the issue for me without reintroducing #1815 :)