Skip to content

Simple install script for ESS CE. #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rxl881
Copy link

@rxl881 rxl881 commented Apr 3, 2025

A simple install script for ESS community edition. Although it works for my use-case, it will need further work for general use. For example it currently only supports installation using wildcard certs (but the other cases can be simply added to the switch statement).

@rxl881 rxl881 requested a review from a team as a code owner April 3, 2025 23:20
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2025

CLA assistant check
All committers have signed the CLA.

@benbz
Copy link
Member

benbz commented Apr 15, 2025

Hi Rick, thanks for providing this initial PR of your install script. As you say further work would be required to get this merged for general use. (Not a full review) Some initial things that that stand out to me as being needed before we can thank about merging it:

  • Added to the documentation
  • Moved into the scripts folder and renamed to distinguish it from scripts/setup_test_cluster.sh (scripts/setup_k3s_and_install.sh?)
  • Needs to handle matrixRTC given that's now in the quick setup values files since this PR was created
  • How safe is the script to re-run, appreciating that while you've got y/N around various steps, people will still blindly hit y?
  • Implementing the individual certs case would be good
    • This might be easier using yq rather than sed
  • I don't think there's anything much to do for the external reverse proxy setup so not bailing out would be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants