Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Room List: Create new labs flag #29239

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Conversation

MidhunSureshR
Copy link
Member

@MidhunSureshR MidhunSureshR commented Feb 11, 2025

  • Introduces lab flag for the new room list
  • Create a base RoomListView for further development.
  • Existing RoomList has been renamed to LegacyRoomList

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets please not create a labs flag which does nothing, this creates an unnecessary support burden in the public support room due to confusion and it feeling broken from day0. Also all labs flags need documenting in labs.md

Copy link
Member

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour to call the new room list RoomListView and to rename the legacy room list LegacyRoomList in the LeftPanel import.

When we will delab the new room list, we will not have to rename it from NewRoomListView to RoomListView. Also using LegacyRoomList in the import will inform contributors that this room list will be removed in X times.

and rename NewRoomListView.tsx to RoomListView.tsx
@dbkr dbkr merged commit 03a5ee1 into develop Feb 12, 2025
41 of 42 checks passed
@dbkr dbkr deleted the midhun/new-room-list/create-labs-flag branch February 12, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants