-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Room List: Create new labs flag #29239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets please not create a labs flag which does nothing, this creates an unnecessary support burden in the public support room due to confusion and it feeling broken from day0. Also all labs flags need documenting in labs.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favour to call the new room list RoomListView
and to rename the legacy room list LegacyRoomList
in the LeftPanel
import.
When we will delab the new room list, we will not have to rename it from NewRoomListView
to RoomListView
. Also using LegacyRoomList
in the import will inform contributors that this room list will be removed in X times.
and rename NewRoomListView.tsx to RoomListView.tsx
RoomListView
for further development.RoomList
has been renamed toLegacyRoomList