Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer v1.1.0 #23

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Installer v1.1.0 #23

wants to merge 31 commits into from

Conversation

stephenhensley
Copy link
Contributor

So this is based on the installer branch, which should be what was used for the v1.0 toolchain installer for windows.

I've replaced all of the windows folder files for openocd with v0.12.0

beserge and others added 29 commits September 20, 2021 12:47
The information for how to use NSIS templates with cpack  exists nowhere on the internet.
I was able to find a git repo (opensim-gui) which does it by chance.
Default PATH was selected in menu, but the value wasnt being reflected in the code.
I manually set the $ADD_TO_PATH_CURRENT_USER var to 1.
@beserge
Copy link
Contributor

beserge commented May 19, 2023

Updated CMake files and NSIS templates for new Windows installer.
Uploaded the new bin on jira card
We'll need to submit the installer again here when we're ready to get rid of the windows protected your PC stuff like we did last time

Should be noted, the 1.1.0 installer just adds files to the existing install if 1.0.0 is already installed. I tested and it does upgrade openocd, but there could be some weirdness in the future due to this behavior.

We either need to figure out how to get NSIS to remove the folder before installing, or warn users to uninstall before upgrading.
Doesn't seem to break anything with this version, but something to be aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants