[8.x] [ResponseOps][Alerts] Remove fieldsForAad attribute from rule type registry (#215767) #217649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gistry (elastic#215767) ## Summary Implements elastic#215338 This PR removes `fieldsForAAD ` and `hasFieldsForAAD ` from the rule type registry and all corresponding rule types. It uses existing `getBrowserFieldsByFeatureId ` route to fetch fields from [field_caps](https://www.elastic.co/guide/en/elasticsearch/reference/8.17/search-field-caps.html) API. It also updates `getBrowserFieldsByFeatureId` route - to use `include_empty_fields: false` query param to fetch only non empty fields to have limited number of fields - to use `index filter` to fetch fields only from last 90 days for better performance ``` const indexFilter = { range: { '@timestamp': { gte: 'now-90d', }, }, }; ``` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Flaky Test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8151 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit adbc6d9) # Conflicts: # x-pack/test/observability_functional/apps/observability/pages/alerts/index.ts
botelastic
bot
added
ci:project-deploy-observability
2 tasks
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
cnasikas
approved these changes
Apr 10, 2025
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation