[Obs AI Assistant] Fix bug with get_alerts_dataset_info
#212077
Merged
+46
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
sorenlouv
added
backport:prev-minor
sorenlouv
commented
Feb 21, 2025
| // remove the function request | ||
| ...messages.filter((msg) => !msg.message?.function_call), | ||
| // remove the last function request | ||
| ...messages.slice(0, -1), |
There was a problem hiding this comment.
This was the root cause. The rest of the PR is just adding logs to aid in debugging
viduni94
approved these changes
Feb 21, 2025
|
Starting backport for target branches: 8.x, 9.0 |
💚 Build Succeeded
Metrics [docs]
History
|
|
Merging now due to the urgency. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 22, 2025
…2077) Closes elastic#212005 Regression introduced in: https://github.com/elastic/kibana/pull/209773/files#diff-83722bb07633512b20beb965628b18290628de985d399989011cc20c82fa483cL116 TODO: - Add a test that would have caught this (cherry picked from commit 54f96d0)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 22, 2025
) (#212181) # Backport This will backport the following commits from `main` to `9.0`: - [[Obs AI Assistant] Fix bug with `get_alerts_dataset_info` (#212077)](#212077) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2025-02-22T11:50:14Z","message":"[Obs AI Assistant] Fix bug with `get_alerts_dataset_info` (#212077)\n\nCloses https://github.com/elastic/kibana/issues/212005\n\nRegression introduced in:\nhttps://github.com//pull/209773/files#diff-83722bb07633512b20beb965628b18290628de985d399989011cc20c82fa483cL116\n\nTODO:\n\n- Add a test that would have caught this","sha":"54f96d0070306bf13eeace9a55a157b5a8341526","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Obs AI Assistant","backport:version","v9.1.0","v8.19.0"],"title":"[Obs AI Assistant] Fix bug with `get_alerts_dataset_info`","number":212077,"url":"https://github.com/elastic/kibana/pull/212077","mergeCommit":{"message":"[Obs AI Assistant] Fix bug with `get_alerts_dataset_info` (#212077)\n\nCloses https://github.com/elastic/kibana/issues/212005\n\nRegression introduced in:\nhttps://github.com//pull/209773/files#diff-83722bb07633512b20beb965628b18290628de985d399989011cc20c82fa483cL116\n\nTODO:\n\n- Add a test that would have caught this","sha":"54f96d0070306bf13eeace9a55a157b5a8341526"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212077","number":212077,"mergeCommit":{"message":"[Obs AI Assistant] Fix bug with `get_alerts_dataset_info` (#212077)\n\nCloses https://github.com/elastic/kibana/issues/212005\n\nRegression introduced in:\nhttps://github.com//pull/209773/files#diff-83722bb07633512b20beb965628b18290628de985d399989011cc20c82fa483cL116\n\nTODO:\n\n- Add a test that would have caught this","sha":"54f96d0070306bf13eeace9a55a157b5a8341526"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212005
Regression introduced in: https://github.com/elastic/kibana/pull/209773/files#diff-83722bb07633512b20beb965628b18290628de985d399989011cc20c82fa483cL116
TODO: