-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Additional datastreams permissions API #210452
[Fleet] Additional datastreams permissions API #210452
Conversation
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
… src/core/server/integration_tests/ci_checks'
…nnal-datastream-permissions-api
…ub.com:nchaulet/kibana into feature-additionnal-datastream-permissions-api
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
…ub.com:nchaulet/kibana into feature-additionnal-datastream-permissions-api
…ub.com:nchaulet/kibana into feature-additionnal-datastream-permissions-api
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kibana Security changes LGTM. No changes to encrypted saved object types.
...ns/shared/fleet/server/services/agent_policies/package_policies_to_agent_permissions.test.ts
Outdated
Show resolved
Hide resolved
...plugins/shared/fleet/server/services/agent_policies/package_policies_to_agent_permissions.ts
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/fleet/server/services/spaces/policy_namespaces.ts
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/fleet/server/types/models/package_policy.ts
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/fleet/server/types/models/package_policy.ts
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/fleet/server/types/models/package_policy.ts
Show resolved
Hide resolved
…ge_policy.ts Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
…b.com:nchaulet/kibana into feature-additionnal-datastream-permissions-api
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
…ub.com:nchaulet/kibana into feature-additionnal-datastream-permissions-api
…icies/package_policies_to_agent_permissions.test.ts Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
…ub.com:nchaulet/kibana into feature-additionnal-datastream-permissions-api
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Related to #203585
Add a new
additional_datastreams_permissions
properties to the fleet package policies APIThat property allow to define extra permissions that will be added to the generated agent policy. This is usefull for user using the
reroute
processor in their ingest pipeline.Tests
I added API integration tests.
Working on adding a e2e test with a reroute processor.
You can test by creating a package policy with
additional_datastreams_permissions
and check the permission are in the generated policy