Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nvidia/GPU] Introduce Nvidia GPU Integration #12768

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

strawgate
Copy link
Contributor

Proposed commit message

Introduce NVIDIA GPU Monitoring Integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

How to test this PR locally

Deploy NVIDIA DGCM on a device with an NVIDIA GPU to get a prometheus metrics endpoint that you can provide to the integration.

If you have docker this just requires:

docker run -d --gpus all --rm -p 9400:9400 nvcr.io/nvidia/k8s/dcgm-exporter:3.3.9-3.6.1-ubuntu22.04
curl localhost:9400/metrics

Configure the integration to point at the host running the container and GPU http://nvidiahost:9400/metrics

Some metrics are not enabled by default with the container, enabling all metrics requires some extra steps.

Related issues

Fixes #11930

Screenshots

WIP:

bill-easton-test kb us-central1 gcp cloud es io_9243_app_dashboards (1)
bill-easton-test kb us-central1 gcp cloud es io_9243_app_dashboards

@strawgate
Copy link
Contributor Author

Todo: Add k8s container, pod, and namespace info from labels

Should also include labels / mapping for kubernetes container, pod, and namespace

container="dcgmproftester11",namespace="default",pod="dcgmproftester"

container => kubernetes.container.name
namespace => kubernetes.namespace
pod => kubernetes.pod.name

- name: kubernetes
  type: group
  fields:
    - name: pod.name
      type: keyword
      description: >
        Kubernetes pod name
    - name: container.name
      type: keyword
      description: >
        Kubernetes container name
    - name: namespace
      type: keyword
      description: >
        Kubernetes namespace
- rename:
    field: prometheus.labels.container
    target_field: kubernetes.container.name
    ignore_missing: true
- rename:
    field: prometheus.labels.namespace
    target_field: kubernetes.namespace
    ignore_missing: true
- rename:
    field: prometheus.labels.pod
    target_field: kubernetes.pod.name
    ignore_missing: true

Perhaps with corresponding dashboard elements

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
Shared inital set of comments from the 1st review.

- {{this}}
{{/each}}
period: {{period}}
use_types: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want these options to be configurable ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ingest pipeline and mappings expect a certain format coming from the prometheus input of metricbeat, i believe changing these will change the format and the ingest pipeline/mappings will not be valid

target_field: gpu.nvlink.bandwidth.total
ignore_missing: true
- rename:
field: prometheus.DCGM_FI_DEV_GPU_UTIL.value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While going through this issue, there is a mention about

  • high resource utilisation
  • deprecation of a few metrics including DCGM_FI_DEV_GPU_UTIL.

Is this scenario observed while integration testing? If there are metrics that are deprecated or result in high resource intensive, it would be best to not consider this metric for creating dashboard visualisation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove this metric and consider replacing with the referenced ones

@agithomas
Copy link
Contributor

Added @daniela-elastic as the reviewer for the dashboard.

@elasticmachine
Copy link

elasticmachine commented Feb 19, 2025

💔 Build Failed

Failed CI Steps

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nvidia GPU] New Integration for Nvidia GPU Monitoring
4 participants