Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packages/salesforce: add dashboards #10341

Merged
merged 21 commits into from
Jul 11, 2024
Merged

packages/salesforce: add dashboards #10341

merged 21 commits into from
Jul 11, 2024

Conversation

kush-elastic
Copy link
Collaborator

Description

This PR introduces a new dashboards for the below mentioned datastream in Salesforce Integration:

  • Login
  • Logout
  • Apex
  • Setup Audit Trail

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kush-elastic kush-elastic requested a review from a team as a code owner July 3, 2024 04:07
@kush-elastic kush-elastic self-assigned this Jul 3, 2024
@kush-elastic kush-elastic added enhancement New feature or request Integration:kibana Kibana dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:salesforce Salesforce Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jul 3, 2024
@kush-elastic
Copy link
Collaborator Author

/test

@elasticmachine
Copy link

elasticmachine commented Jul 3, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@shmsr
Copy link
Member

shmsr commented Jul 3, 2024

All dashboards done?

@shmsr
Copy link
Member

shmsr commented Jul 3, 2024 •
edited
Loading

Fixed user_initiated_logout's type when I noticed this:

kql='salesforce.logout.user_initiated_logout : \"1\" ')/count()"

See 1 is escaped as it is a keyword. Also as per doc it is boolean.

harnish-elastic
harnish-elastic approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ali786XI
Copy link
Contributor

ali786XI commented Jul 5, 2024

I just re exported the dashboards and there were changes in the SetupAuditTrail and Login dashboards control panels length which are now made consistent with the other dashboards.

@kush-elastic
Copy link
Collaborator Author

@kush-elastic You found the issue?

Yes, I also have fixed it in last commit.

harnish-elastic
harnish-elastic approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

shmsr
shmsr approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's GO 🚀

harnish-elastic
harnish-elastic approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Minor suggestions given.

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
99.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @kush-elastic

ali786XI
ali786XI approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kush-elastic kush-elastic merged commit e60bead into elastic:main Jul 11, 2024
5 checks passed
@elasticmachine
Copy link

Package salesforce - 0.15.0 containing this change is available at https://epr.elastic.co/search?package=salesforce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmsr shmsr shmsr approved these changes

@harnish-elastic harnish-elastic harnish-elastic approved these changes

@milan-elastic milan-elastic milan-elastic approved these changes

@ali786XI ali786XI ali786XI approved these changes

Assignees

@kush-elastic kush-elastic

Labels
breaking change dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:salesforce Salesforce Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kush-elastic @elasticmachine @shmsr @ali786XI @harnish-elastic @milan-elastic @andrewkroh