add proper cleanup callback

elastic · Mar 4, 2024 · ea6fba2 · ea6fba2
1 parent b784e52
commit ea6fba2
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/metric/system/process/process_linux_test.go b/metric/system/process/process_linux_test.go
@@ -94,6 +94,13 @@ func TestRunningProcessFromOtherUser(t *testing.T) {
 	require.NoError(t, err)
 	t.Logf("uid: %v", uid)
 
+	t.Cleanup(func() {
+		// not sure how ephemeral the CI environment is, but delete the user anyway
+		cmd := exec.Command("userdel", "-f", testUsername)
+		output, err := cmd.CombinedOutput()
+		require.NoError(t, err, "got error deleting user: %s", string(output))
+	})
+
 	cmdHandler := exec.Command("sleep", "60")
 	cmdHandler.SysProcAttr = &syscall.SysProcAttr{Credential: &syscall.Credential{Uid: uint32(uid), Gid: 0}}
 
@@ -122,10 +129,6 @@ func TestRunningProcessFromOtherUser(t *testing.T) {
 	require.NotZero(t, result["memory"].(map[string]interface{})["size"])
 	t.Logf("got result: %s", result["username"])
 
-	// not sure how ephemeral the Ci environment is, but delete the user anyway
-	cmd := exec.Command("userdel", "-f", testUsername)
-	output, err := cmd.CombinedOutput()
-	require.NoError(t, err, "got error deleting user: %s", string(output))
 }
 
 func TestFetchProcessFromOtherUser(t *testing.T) {