[Lookup] Relax input datatype constraints #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
bwintermann
reviewed
Jan 29, 2025
|
I think we can merge this without issue but if it can wait we should maybe wait until the new logging from #14 is ready, so that this warning doesn't drown in a sea of unimportant warnings, since ignoring the type assertion looks like it could trip somebody up really easily if they are not familiar with this part of FINN. |
|
Hm, yes I will go through some coordinated refactoring of all the warnings and and error messages once everything is functionally correct and complete again, as a last thing before merging - this probably applies to most of my PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FINN and QONNX generally assume float32 as the container datatype of tensors. However, Gather/Lookup export with int64 tensors as the index input, which makes more sense, but is not properly handled by our compiler infrastructure. Instead of refactoring container datatype handling throughout the code base, for now it seems to be sufficient to disable some assertions or at least relax them to warnings. A proper refactoring of the Lookup operator might be necessary in the near future anyway.
See mirror PR Xilinx#1267