-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: upgraded python to 3.12 and django to 4.2 #97
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good but let's test the docker build locally with the updated Dockerfile to make sure it doesn't break the pipeline after deployment.
50cdc17
to
be885f2
Compare
d8dda58
to
b6a9ae8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, I have added a couple of questions though. I have tested the service locally and things look good. I will give the testing phase another pass once the changes are on staging.
Hi @aht007 , I have reverted the testing code. Please let me know if the PR is good to go. |
f699353
to
d823f59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, lets test this on staging before rolling out to production.
Merge checklist:
Check off if complete or not applicable:
Post-merge: