Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgraded python to 3.12 and django to 4.2 #97

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

huniafatima-99
Copy link
Member

@huniafatima-99 huniafatima-99 commented Feb 12, 2025

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

@huniafatima-99 huniafatima-99 requested a review from a team as a code owner February 12, 2025 14:09
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  sanctions
  __init__.py
  sanctions/apps/sanctions/management/commands
  populate_sdn_fallback_data_and_metadata.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but let's test the docker build locally with the updated Dockerfile to make sure it doesn't break the pipeline after deployment.

@huniafatima-99 huniafatima-99 changed the title chore: upgraded python to 3.12 and django to 4.2 feat!: upgraded python to 3.12 and django to 4.2 Feb 17, 2025
@huniafatima-99 huniafatima-99 force-pushed the hunia/upgrade-python-and-django branch from 50cdc17 to be885f2 Compare February 17, 2025 16:02
@huniafatima-99 huniafatima-99 force-pushed the hunia/upgrade-python-and-django branch from d8dda58 to b6a9ae8 Compare February 18, 2025 13:04
Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, I have added a couple of questions though. I have tested the service locally and things look good. I will give the testing phase another pass once the changes are on staging.

@huniafatima-99
Copy link
Member Author

Looks reasonable, I have added a couple of questions though. I have tested the service locally and things look good. I will give the testing phase another pass once the changes are on staging.

Hi @aht007 , I have reverted the testing code. Please let me know if the PR is good to go.

@huniafatima-99 huniafatima-99 force-pushed the hunia/upgrade-python-and-django branch from f699353 to d823f59 Compare February 21, 2025 10:22
Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets test this on staging before rolling out to production.

@aht007 aht007 closed this Feb 24, 2025
@aht007 aht007 reopened this Feb 24, 2025
@aht007 aht007 merged commit 6e8d7f5 into main Feb 24, 2025
18 checks passed
@aht007 aht007 deleted the hunia/upgrade-python-and-django branch February 24, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants